Add eager workflow start sample #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Mar 6, 2024
Comment on lines
+41
to
+42
| // 3. Set this flag to true to enable EWS. | ||
| EnableEagerStart: true, |
There was a problem hiding this comment.
Hrmm, wonder if it's a bit much to have an entire sample just to set true on a single workflow option (I wouldn't expect separate samples for every other start option). But I don't mind I guess if it makes sense generally.
There was a problem hiding this comment.
I think it is worth making a sample for since it also shows you have to reuse the client
Quinn-With-Two-Ns
approved these changes
Mar 6, 2024
| @@ -0,0 +1,10 @@ | |||
| ### Steps to run this sample: | |||
There was a problem hiding this comment.
Can we add a short description here about eager workflow start and how the sample works like some of our other samples?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Add an example of starting a workflow in eager mode, a latency optimization.
Why?
We are launching this feature in PreRelease soon
Checklist
[Feature Request] Add Eager Workflow Start sample #333